]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/internal/obj/arm64: do not clear environment in TestLarge and TestNoRet
authorAlex Brainman <alex.brainman@gmail.com>
Sat, 14 Apr 2018 04:14:28 +0000 (14:14 +1000)
committerBrad Fitzpatrick <bradfitz@golang.org>
Sat, 14 Apr 2018 05:18:41 +0000 (05:18 +0000)
Windows process cannot run properly, if it only has
GOOS and GOARCH environment variables set. It needs
other environment variables. So adjust TestLarge and
TestNoRet to add GOOS and GOARCH to the existing
variables set instead of clearing environment.

Fixes #24855

Change-Id: I9fd9430d89031c3bacdbc6283450efaa4819e616
Reviewed-on: https://go-review.googlesource.com/107035
Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/cmd/internal/obj/arm64/asm_test.go

index 68f5b0b3464e83432fdfbba01834b80204766de5..21823012127d99a951b65235b57db6ac76410ae1 100644 (file)
@@ -42,7 +42,7 @@ func TestLarge(t *testing.T) {
 
        // build generated file
        cmd := exec.Command(testenv.GoToolPath(t), "tool", "asm", "-o", filepath.Join(dir, "x.o"), tmpfile)
-       cmd.Env = []string{"GOARCH=arm64", "GOOS=linux"}
+       cmd.Env = append(os.Environ(), "GOARCH=arm64", "GOOS=linux")
        out, err := cmd.CombinedOutput()
        if err != nil {
                t.Errorf("Build failed: %v, output: %s", err, out)
@@ -74,7 +74,7 @@ func TestNoRet(t *testing.T) {
                t.Fatal(err)
        }
        cmd := exec.Command(testenv.GoToolPath(t), "tool", "asm", "-o", filepath.Join(dir, "x.o"), tmpfile)
-       cmd.Env = []string{"GOARCH=arm64", "GOOS=linux"}
+       cmd.Env = append(os.Environ(), "GOARCH=arm64", "GOOS=linux")
        if out, err := cmd.CombinedOutput(); err != nil {
                t.Errorf("%v\n%s", err, out)
        }