]> Cypherpunks repositories - gostls13.git/commitdiff
math/bits: remove named return in TrailingZeros16
authorAlberto Donizetti <alb.donizetti@gmail.com>
Sun, 9 Dec 2018 12:37:17 +0000 (13:37 +0100)
committerBrad Fitzpatrick <bradfitz@golang.org>
Sun, 9 Dec 2018 14:27:56 +0000 (14:27 +0000)
TrailingZeros16 is the only one of the TrailingZeros functions with a
named return value in the signature. This creates a sligthly
unpleasant effect in the godoc listing:

  func TrailingZeros(x uint) int
  func TrailingZeros16(x uint16) (n int)
  func TrailingZeros32(x uint32) int
  func TrailingZeros64(x uint64) int
  func TrailingZeros8(x uint8) int

Since the named return value is not even used, remove it.

Change-Id: I15c5aedb6157003911b6e0685c357ce56e466c0e
Reviewed-on: https://go-review.googlesource.com/c/153340
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/math/bits/bits.go

index 9da1c6e580a99ea0f1e1e58c5ff9c69142bc6dd8..b06c363348449d145b04a4c7182ba76a3046f6dc 100644 (file)
@@ -65,7 +65,7 @@ func TrailingZeros8(x uint8) int {
 }
 
 // TrailingZeros16 returns the number of trailing zero bits in x; the result is 16 for x == 0.
-func TrailingZeros16(x uint16) (n int) {
+func TrailingZeros16(x uint16) int {
        if x == 0 {
                return 16
        }