cmd/doc: use strings.Builder

Change-Id: Ib33d1f1c2e9aed0cb9e00bd699c4ae4a2df5dfca
Reviewed-on: https://go-review.googlesource.com/c/go/+/428288
Run-TryBot: Rob Pike <r@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Rob Pike <r@golang.org>
Auto-Submit: Rob Pike <r@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>

diff --git a/src/cmd/doc/doc_test.go b/src/cmd/doc/doc_test.go
index 5887ad3395b19a2bb5754f42dc662fd1e70ff0d2..6a259ae19e35bfa62b1a2a2b07ff2177a163ecc9 100644 (file)
--- a/src/cmd/doc/doc_test.go
+++ b/src/cmd/doc/doc_test.go
@@ -1012,7 +1012,7 @@ func TestDotSlashLookup(t *testing.T) {
        if err := os.Chdir(filepath.Join(buildCtx.GOROOT, "src", "text")); err != nil {
                t.Fatal(err)
        }
-       var b bytes.Buffer
+       var b strings.Builder
        var flagSet flag.FlagSet
        err = do(&b, &flagSet, []string{"./template"})
        if err != nil {
@@ -1030,7 +1030,7 @@ func TestDotSlashLookup(t *testing.T) {
 // when there should be no output at all. Issue 37969.
 func TestNoPackageClauseWhenNoMatch(t *testing.T) {
        maybeSkip(t)
-       var b bytes.Buffer
+       var b strings.Builder
        var flagSet flag.FlagSet
        err := do(&b, &flagSet, []string{"template.ZZZ"})
        // Expect an error.

diff --git a/src/cmd/doc/pkg.go b/src/cmd/doc/pkg.go
index 35f2eb24bf2fc1967cce90f3ac13418f911ba7c0..4cebdc957ada427bc376c7131a1753f995c759df 100644 (file)
--- a/src/cmd/doc/pkg.go
+++ b/src/cmd/doc/pkg.go
@@ -420,7 +420,7 @@ func (pkg *Package) oneLineNodeDepth(node ast.Node, depth int) string {
 
        default:
                // As a fallback, use default formatter for all unknown node types.
-               buf := new(bytes.Buffer)
+               buf := new(strings.Builder)
                format.Node(buf, pkg.fs, node)
                s := buf.String()
                if strings.Contains(s, "\n") {