]> Cypherpunks repositories - gostls13.git/commitdiff
syscall: skip TestUnshare on Linux upon permission error
authorBrad Fitzpatrick <bradfitz@golang.org>
Fri, 14 Jul 2017 19:02:05 +0000 (19:02 +0000)
committerBrad Fitzpatrick <bradfitz@golang.org>
Fri, 14 Jul 2017 21:05:21 +0000 (21:05 +0000)
Fixes #17206

Change-Id: Id0ebc3a55ea1c5f52608decffee04c8398a8774b
Reviewed-on: https://go-review.googlesource.com/48571
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/syscall/exec_linux_test.go

index f5e97bec1f5c3ffb9bcd7b73a4572e16cc6bdfa7..5c7d8a29c18cc6283f77cc7ada0340c28b4d8dc8 100644 (file)
@@ -182,6 +182,12 @@ func TestUnshare(t *testing.T) {
        }
        out, err := cmd.CombinedOutput()
        if err != nil {
+               if strings.Contains(err.Error(), "operation not permitted") {
+                       // Issue 17206: despite all the checks above,
+                       // this still reportedly fails for some users.
+                       // (older kernels?). Just skip.
+                       t.Skip("skipping due to permission error")
+               }
                t.Fatalf("Cmd failed with err %v, output: %s", err, out)
        }