]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/dist: run misc/cgo/testsovar on darwin and netbsd
authorIan Lance Taylor <iant@golang.org>
Mon, 27 Jul 2015 17:30:26 +0000 (10:30 -0700)
committerIan Lance Taylor <iant@golang.org>
Mon, 27 Jul 2015 18:10:26 +0000 (18:10 +0000)
CL https://golang.org/cl/12470 has reportedly fixed the problems that
the misc/cgo/testsovar test encountered on darwin and netbsd.  Let's
actually run the test.

Update #10360.
Update #11654.

Change-Id: I4cdd27a8ec8713620e0135780a03f63cfcc538d0
Reviewed-on: https://go-review.googlesource.com/12702
Reviewed-by: Russ Cox <rsc@golang.org>
src/cmd/dist/test.go

index 9f6e06e0142f4668ebbb258be4c51b279b9f0db9..d0e634640c067d1abb8264fab318f548f8635b1c 100755 (executable)
@@ -418,20 +418,13 @@ func (t *tester) registerTests() {
                                        return t.cgoTestSO("misc/cgo/testso")
                                },
                        })
-                       switch t.goos {
-                       case "darwin":
-                               // Skipping misc/cgo/testsovar test. See issue 10360 for details.
-                       case "netbsd":
-                               // Skipping misc/cgo/testsovar test. See issue 11654 for details.
-                       default:
-                               t.tests = append(t.tests, distTest{
-                                       name:    "testsovar",
-                                       heading: "../misc/cgo/testsovar",
-                                       fn: func() error {
-                                               return t.cgoTestSO("misc/cgo/testsovar")
-                                       },
-                               })
-                       }
+                       t.tests = append(t.tests, distTest{
+                               name:    "testsovar",
+                               heading: "../misc/cgo/testsovar",
+                               fn: func() error {
+                                       return t.cgoTestSO("misc/cgo/testsovar")
+                               },
+                       })
                }
                if t.supportedBuildmode("c-archive") {
                        t.registerTest("testcarchive", "../misc/cgo/testcarchive", "./test.bash")