]> Cypherpunks repositories - gostls13.git/commitdiff
exp/cookiejar: add a test for canonicalHost errors.
authorNigel Tao <nigeltao@golang.org>
Wed, 27 Feb 2013 02:05:57 +0000 (13:05 +1100)
committerNigel Tao <nigeltao@golang.org>
Wed, 27 Feb 2013 02:05:57 +0000 (13:05 +1100)
R=dr.volker.dobler
CC=golang-dev
https://golang.org/cl/7389048

src/pkg/exp/cookiejar/jar_test.go

index 286f1c4088d8dedb219c3185431996b89498e755..bc17e93603dca4359d66ca675635f9830820f798 100644 (file)
@@ -51,15 +51,26 @@ var canonicalHostTests = map[string]string{
        "[2001:4860:0:::68]:8080": "2001:4860:0:::68",
        "www.bücher.de":           "www.xn--bcher-kva.de",
        "www.example.com.":        "www.example.com",
+       "[bad.unmatched.bracket:": "error",
 }
 
 func TestCanonicalHost(t *testing.T) {
        for h, want := range canonicalHostTests {
-               got, _ := canonicalHost(h)
+               got, err := canonicalHost(h)
+               if want == "error" {
+                       if err == nil {
+                               t.Errorf("%q: got nil error, want non-nil", h)
+                       }
+                       continue
+               }
+               if err != nil {
+                       t.Errorf("%q: %v", h, err)
+                       continue
+               }
                if got != want {
                        t.Errorf("%q: got %q, want %q", h, got, want)
+                       continue
                }
-               // TODO handle errors
        }
 }