]> Cypherpunks repositories - gostls13.git/commitdiff
syscall: do not load native libraries on non-native powershell on arm
authorJason A. Donenfeld <Jason@zx2c4.com>
Fri, 11 Jun 2021 15:36:50 +0000 (17:36 +0200)
committerJason A. Donenfeld <Jason@zx2c4.com>
Fri, 11 Jun 2021 20:31:30 +0000 (20:31 +0000)
The powershell that currently ships on ARM Windows isn't native, so it
won't load native DLLs. So just skip the tests for now, and reenable it
if this ever changes.

Updates #46701.

Change-Id: I2559fdf13cb65d3ecdc4c6f6df7dec1b490b9651
Reviewed-on: https://go-review.googlesource.com/c/go/+/327210
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Trust: Jason A. Donenfeld <Jason@zx2c4.com>
Run-TryBot: Jason A. Donenfeld <Jason@zx2c4.com>

src/syscall/syscall_windows_test.go

index ea8fa191dcb4f33d913fada121fb04023c29d98c..3243952ded104f1fd7605c974c759710655cb8d2 100644 (file)
@@ -10,6 +10,7 @@ import (
        "os"
        "os/exec"
        "path/filepath"
+       "runtime"
        "strings"
        "syscall"
        "testing"
@@ -79,6 +80,9 @@ func TestTOKEN_ALL_ACCESS(t *testing.T) {
 func TestStdioAreInheritable(t *testing.T) {
        testenv.MustHaveGoBuild(t)
        testenv.MustHaveExecPath(t, "gcc")
+       if runtime.GOARCH == "arm64" || runtime.GOARCH == "arm" {
+               t.Skip("Powershell is not native on ARM; see golang.org/issues/46701")
+       }
 
        tmpdir := t.TempDir()