]> Cypherpunks repositories - gostls13.git/commitdiff
slices: simplify slice expression for Replace
authorJes Cok <xigua67damn@gmail.com>
Sat, 30 Mar 2024 02:32:20 +0000 (10:32 +0800)
committerGopher Robot <gobot@golang.org>
Wed, 3 Apr 2024 17:01:23 +0000 (17:01 +0000)
A slice expression of the form:
s[a:len(s)]
will be simplified to:
s[a:]
This is one of the simplifications that "gofmt -s" applies.

See https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/simplifyslice

Change-Id: Ib3c01ecf24b84333fd1993a343450fc57fb8ac84
Reviewed-on: https://go-review.googlesource.com/c/go/+/575335
Reviewed-by: Ian Lance Taylor <iant@google.com>
Commit-Queue: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Valentin Deleplace <deleplace@google.com>
src/slices/slices.go

index 271e8cb32559270ba1d4877942383c8e03db64bb..a5734a17bf496bf6559382e6d3c3d32515529b55 100644 (file)
@@ -261,7 +261,7 @@ func Replace[S ~[]E, E any](s S, i, j int, v ...E) S {
        if j == len(s) {
                s2 := append(s[:i], v...)
                if len(s2) < len(s) {
-                       clear(s[len(s2):len(s)]) // zero/nil out the obsolete elements, for GC
+                       clear(s[len(s2):]) // zero/nil out the obsolete elements, for GC
                }
                return s2
        }