]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/go: skip flaky TestCgoConsistentResults on FreeBSD
authorMikio Hara <mikioh.mikioh@gmail.com>
Wed, 21 Dec 2016 23:59:52 +0000 (08:59 +0900)
committerMikio Hara <mikioh.mikioh@gmail.com>
Thu, 22 Dec 2016 09:05:25 +0000 (09:05 +0000)
FreeBSD 11 or above uses clang-3.6 or higher by default.

Updates #15405.

Change-Id: If49ce298130165f9e1525c7fd0fd5aa39099ad53
Reviewed-on: https://go-review.googlesource.com/34675
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/cmd/go/go_test.go

index 88c54432fba2cf365d2722f7d9a8a8dfffb4afa0..5665eb745ab368eda4a34276ad89d98749eefbe4 100644 (file)
@@ -3357,9 +3357,11 @@ func TestCgoConsistentResults(t *testing.T) {
        if !canCgo {
                t.Skip("skipping because cgo not enabled")
        }
-       if runtime.GOOS == "solaris" {
-               // See https://golang.org/issue/13247
-               t.Skip("skipping because Solaris builds are known to be inconsistent; see #13247")
+       switch runtime.GOOS {
+       case "freebsd":
+               testenv.SkipFlaky(t, 15405)
+       case "solaris":
+               testenv.SkipFlaky(t, 13247)
        }
 
        tg := testgo(t)