]> Cypherpunks repositories - gostls13.git/commitdiff
[release-branch.go1.18] cmd/go/internal/imports: include ToolTags in the Tags map
authorZeke Lu <lvzecai@gmail.com>
Thu, 25 Aug 2022 04:17:00 +0000 (04:17 +0000)
committerHeschi Kreinick <heschi@google.com>
Mon, 29 Aug 2022 19:17:24 +0000 (19:17 +0000)
This fixes a regression introduced when the "race" mode tag was moved to
the ToolTags field in CL 358539.

Fixes #54659
Updates #54468

Change-Id: I107771948a4fe9d743cc13d1c15f324212b08e03
GitHub-Last-Rev: d211e351ef3331f2c38b16d327d992a32ebbfe30
GitHub-Pull-Request: golang/go#54618
Reviewed-on: https://go-review.googlesource.com/c/go/+/425154
Reviewed-by: David Chase <drchase@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 6ba2674ddc5373f261211ba5ebc38496dc660604)
Reviewed-on: https://go-review.googlesource.com/c/go/+/426435
Reviewed-by: Heschi Kreinick <heschi@google.com>
src/cmd/go/internal/imports/tags.go
src/cmd/go/testdata/script/test_race_tag.txt [new file with mode: 0644]

index 01b448b9142e57729bd19fdb380be7822cb08feb..d1467b81b0b66083a3542ca0b27f9829500eb682 100644 (file)
@@ -36,6 +36,9 @@ func loadTags() map[string]bool {
        for _, tag := range cfg.BuildContext.BuildTags {
                tags[tag] = true
        }
+       for _, tag := range cfg.BuildContext.ToolTags {
+               tags[tag] = true
+       }
        for _, tag := range cfg.BuildContext.ReleaseTags {
                tags[tag] = true
        }
diff --git a/src/cmd/go/testdata/script/test_race_tag.txt b/src/cmd/go/testdata/script/test_race_tag.txt
new file mode 100644 (file)
index 0000000..4b18ebc
--- /dev/null
@@ -0,0 +1,29 @@
+# Tests Issue #54468
+
+[short] skip 'links a test binary'
+[!race] skip
+
+go mod tidy
+go test -c -o=$devnull -race .
+
+! stderr 'cannot find package'
+
+-- go.mod --
+module testrace
+
+go 1.18
+
+require rsc.io/sampler v1.0.0
+-- race_test.go --
+//go:build race
+
+package testrace
+
+import (
+        "testing"
+
+        _ "rsc.io/sampler"
+)
+
+func TestRaceTag(t *testing.T) {
+}