]> Cypherpunks repositories - gostls13.git/commitdiff
go/types: enable disabled test for comma-ok expressions
authorRobert Griesemer <gri@golang.org>
Wed, 17 Aug 2016 22:56:29 +0000 (15:56 -0700)
committerRobert Griesemer <gri@golang.org>
Wed, 17 Aug 2016 23:28:20 +0000 (23:28 +0000)
This was fixed long ago but the test was not enabled.

For #8189.

Change-Id: Ia44ef752b6bf076f3e243d2d0db326a392a20193
Reviewed-on: https://go-review.googlesource.com/27310
Run-TryBot: Robert Griesemer <gri@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/go/types/api_test.go

index 60e55de6349ef50e37a4c90c23681cdf0ef308fa..1084de316443b7a18cf7ed9ed70eabcd214c4626 100644 (file)
@@ -171,13 +171,11 @@ func TestTypesInfo(t *testing.T) {
                        `x.(int)`,
                        `(int, bool)`,
                },
-               // TODO(gri): uncomment if we accept issue 8189.
-               // {`package p2; type mybool bool; var m map[string]complex128; var b mybool; func _() { _, b = m["foo"] }`,
-               //      `m["foo"]`,
-               //      `(complex128, p2.mybool)`,
-               // },
-               // TODO(gri): remove if we accept issue 8189.
-               {`package p2; var m map[string]complex128; var b bool; func _() { _, b = m["foo"] }`,
+               {`package p2a; type mybool bool; var m map[string]complex128; var b mybool; func _() { _, b = m["foo"] }`,
+                       `m["foo"]`,
+                       `(complex128, p2a.mybool)`,
+               },
+               {`package p2b; var m map[string]complex128; var b bool; func _() { _, b = m["foo"] }`,
                        `m["foo"]`,
                        `(complex128, bool)`,
                },