]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/dist,internal/platform: temporarily disable race detector on openbsd/amd64
authorJoel Sing <joel@sing.id.au>
Wed, 8 Nov 2023 12:29:50 +0000 (23:29 +1100)
committerJoel Sing <joel@sing.id.au>
Sat, 4 May 2024 07:50:22 +0000 (07:50 +0000)
Unfortunately, LLVM TSAN decided to remove OpenBSD support, which
means that the syso files cannot currently be regenerated (see #52090).
The race_openbsd.syso contains a reference to the syscall symbol,
which has been removed from OpenBSD's libc in 7.5. As such, this
means that the race detector no longer works on openbsd/amd64 (at
least until LLVM TSAN support is reinstated for OpenBSD).

Updates #63900

Change-Id: I3474fc43a94e5197815862b7dc420b71d5e08815
Reviewed-on: https://go-review.googlesource.com/c/go/+/582255
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Joel Sing <joel@sing.id.au>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

src/cmd/dist/test.go
src/internal/platform/supported.go

index 6f4d23182ae2f76561141f54c02bb65b5aa41569..a87c2a1aae5bfd7d71285ce4c1d8cb509d521898 100644 (file)
@@ -1585,7 +1585,7 @@ func raceDetectorSupported(goos, goarch string) bool {
                return goarch == "amd64" || goarch == "ppc64le" || goarch == "arm64" || goarch == "s390x"
        case "darwin":
                return goarch == "amd64" || goarch == "arm64"
-       case "freebsd", "netbsd", "openbsd", "windows":
+       case "freebsd", "netbsd", "windows":
                return goarch == "amd64"
        default:
                return false
index 8f43cbf25f9bfd0778d568c13b520ccbd2a4b462..a774247e6bbc62f031fd68595516142fd7e552ad 100644 (file)
@@ -26,7 +26,7 @@ func RaceDetectorSupported(goos, goarch string) bool {
                return goarch == "amd64" || goarch == "ppc64le" || goarch == "arm64" || goarch == "s390x"
        case "darwin":
                return goarch == "amd64" || goarch == "arm64"
-       case "freebsd", "netbsd", "openbsd", "windows":
+       case "freebsd", "netbsd", "windows":
                return goarch == "amd64"
        default:
                return false