]> Cypherpunks repositories - gostls13.git/commitdiff
[dev.ssa] cmd/compile: detect unbalanced rules
authorJosh Bleecher Snyder <josharian@gmail.com>
Mon, 27 Jul 2015 19:45:56 +0000 (12:45 -0700)
committerJosh Bleecher Snyder <josharian@gmail.com>
Mon, 27 Jul 2015 22:32:28 +0000 (22:32 +0000)
Rules may span multiple lines,
but if we're still unbalanced at the
end of the file, something is wrong.

I write unbalanced rules depressingly often.

Change-Id: Ibd04aa06539e2a0ffef73bb665febf3542fd11f1
Reviewed-on: https://go-review.googlesource.com/12710
Reviewed-by: Keith Randall <khr@golang.org>
src/cmd/compile/internal/ssa/gen/rulegen.go

index 46e0e507c4e72d7d7db84bd88478d3c8e8ad7f24..8dca0bca1f4e86975ab12b2f01f9bfb59ad14b98 100644 (file)
@@ -88,6 +88,9 @@ func genRules(arch arch) {
                }
                rule = ""
        }
+       if unbalanced(rule) {
+               log.Fatalf("unbalanced rule: %v\n", rule)
+       }
        if err := scanner.Err(); err != nil {
                log.Fatalf("scanner failed: %v\n", err)
        }