cmd/pprof/internal/profile: fix missing error check

Fix missing error check.

Spotted by Gordon Klass, https://groups.google.com/forum/#!topic/golang-nuts/MdDLbvOjb4o

Change-Id: I453a0cf032e0077d2622d5b85030310d159b9c4b
Reviewed-on: https://go-review.googlesource.com/10606
Reviewed-by: Nigel Tao <nigeltao@golang.org>

diff --git a/src/cmd/pprof/internal/profile/profile.go b/src/cmd/pprof/internal/profile/profile.go
index 5eb641f7cd207917e18870cf5c2c5eb795214eb8..6d175bf32acb6f8c2614862c58a5db4c8cd0f786 100644 (file)
--- a/src/cmd/pprof/internal/profile/profile.go
+++ b/src/cmd/pprof/internal/profile/profile.go
@@ -125,11 +125,11 @@ func Parse(r io.Reader) (*Profile, error) {
 
        var p *Profile
        if len(orig) >= 2 && orig[0] == 0x1f && orig[1] == 0x8b {
-               var data []byte
-
-               if gz, err := gzip.NewReader(bytes.NewBuffer(orig)); err == nil {
-                       data, err = ioutil.ReadAll(gz)
+               gz, err := gzip.NewReader(bytes.NewBuffer(orig))
+               if err != nil {
+                       return nil, fmt.Errorf("decompressing profile: %v", err)
                }
+               data, err := ioutil.ReadAll(gz)
                if err != nil {
                        return nil, fmt.Errorf("decompressing profile: %v", err)
                }