]> Cypherpunks repositories - gostls13.git/commitdiff
crypto/tls: remove version check when unmarshaling sessionState
authorKatie Hockman <katie@golang.org>
Mon, 18 May 2020 20:49:04 +0000 (16:49 -0400)
committerFilippo Valsorda <filippo@golang.org>
Mon, 18 May 2020 23:09:31 +0000 (23:09 +0000)
This was causing issues when fuzzing with
TestMarshalUnmarshal since the test would
occassionally set the version to VersionTLS13,
which would fail when unmarshaling. The check
doesn't add much in practice, and there is no
harm in removing it to de-flake the test.

Fixes #38902

Change-Id: I0906c570e9ed69c85fdd2c15f1b52f9e372c62e3
Reviewed-on: https://go-review.googlesource.com/c/go/+/234486
Run-TryBot: Katie Hockman <katie@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
src/crypto/tls/ticket.go

index 38b01fc25ca4f0860c8ae4508c5e2bcf4bf21eb2..6c1d20da206daa3166aeb685d2b244e47221216e 100644 (file)
@@ -54,7 +54,6 @@ func (m *sessionState) unmarshal(data []byte) bool {
        *m = sessionState{usedOldKey: m.usedOldKey}
        s := cryptobyte.String(data)
        if ok := s.ReadUint16(&m.vers) &&
-               m.vers != VersionTLS13 &&
                s.ReadUint16(&m.cipherSuite) &&
                readUint64(&s, &m.createdAt) &&
                readUint16LengthPrefixed(&s, &m.masterSecret) &&