]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/go: skip TestExecInDeletedDir on aix and solaris-based platforms
authorBryan C. Mills <bcmills@google.com>
Wed, 5 May 2021 15:24:24 +0000 (11:24 -0400)
committerBryan C. Mills <bcmills@google.com>
Wed, 5 May 2021 16:02:32 +0000 (16:02 +0000)
They empirically do not seem to support deleting the current working
directory.

Updates #34499

Change-Id: I705cdf8b545fbb837d5b75d2904a7c2a89276fa5
Reviewed-on: https://go-review.googlesource.com/c/go/+/317249
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
src/cmd/go/go_test.go

index ff397a1995d7ee13622421d4cd6db6ec418c8999..a059a6dd902a8ee0e7e5832cf8671dbdb5c3aab0 100644 (file)
@@ -2836,9 +2836,11 @@ func TestCoverpkgTestOnly(t *testing.T) {
 // Regression test for golang.org/issue/34499: version command should not crash
 // when executed in a deleted directory on Linux.
 func TestExecInDeletedDir(t *testing.T) {
-       // The crash has only been reproduced on Linux.
-       if runtime.GOOS == "windows" || runtime.GOOS == "plan9" {
-               t.Skip()
+       switch runtime.GOOS {
+       case "windows", "plan9",
+               "aix",                // Fails with "device busy".
+               "solaris", "illumos": // Fails with "invalid argument".
+               t.Skipf("%v does not support removing the current working directory", runtime.GOOS)
        }
        tg := testgo(t)
        defer tg.cleanup()