]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: clarify runtime.GC blocking behavior
authorAustin Clements <austin@google.com>
Sun, 19 Jul 2015 06:22:18 +0000 (23:22 -0700)
committerAustin Clements <austin@google.com>
Sun, 19 Jul 2015 15:10:06 +0000 (15:10 +0000)
The runtime.GC documentation was rewritten in df2809f to make it clear
that it blocks until GC is complete, but the re-rewrite in ed9a4c9 and
e28a679 lost this property when clarifying that it may also block the
entire program and not just the caller.

Try to arrive at wording that conveys both of these properties.

Change-Id: I1e255322aa28a21a548556ecf2a44d8d8ac524ef
Reviewed-on: https://go-review.googlesource.com/12392
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Rob Pike <r@golang.org>
src/runtime/mgc.go

index 068372439f7bc8b2e72a5c9ed2d186b114acf0af..e0818d644163a0fe7dfa671d82a042c58fbaf6f6 100644 (file)
@@ -770,8 +770,9 @@ var work struct {
        initialHeapLive uint64
 }
 
-// GC runs a garbage collection. It might block the entire program until the
-// collection is complete.
+// GC runs a garbage collection and blocks the caller until the
+// garbage collection is complete. It may also block the entire
+// program.
 func GC() {
        startGC(gcForceBlockMode)
 }