]> Cypherpunks repositories - gostls13.git/commitdiff
reflect: remove dead v.typ assignment
authorDaniel Martí <mvdan@mvdan.cc>
Wed, 10 May 2017 16:21:21 +0000 (18:21 +0200)
committerDaniel Martí <mvdan@mvdan.cc>
Thu, 11 May 2017 08:07:21 +0000 (08:07 +0000)
v is not a pointer receiver, and v.typ isn't used in the lines below.
The assignment is dead. Remove it.

Keep the comment, as it refers to the whole case block and not just the
removed line.

Change-Id: Icb2d20c287d9a41bf620ebe5cdec764cd84178a7
Reviewed-on: https://go-review.googlesource.com/43134
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/reflect/value.go

index 290d04d74a652645ca9afb3b6cd6ddb926253757..a84af8cae931be8fb299557ddb0ad9a3521470a3 100644 (file)
@@ -2164,7 +2164,6 @@ func (v Value) assignTo(context string, dst *rtype, target unsafe.Pointer) Value
        case directlyAssignable(dst, v.typ):
                // Overwrite type so that they match.
                // Same memory layout, so no harm done.
-               v.typ = dst
                fl := v.flag & (flagRO | flagAddr | flagIndir)
                fl |= flag(dst.Kind())
                return Value{dst, v.ptr, fl}