]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/compile: remove outdate TODO in inl.go
authorLE Manh Cuong <cuong.manhle.vn@gmail.com>
Thu, 2 May 2019 08:48:14 +0000 (15:48 +0700)
committerBrad Fitzpatrick <bradfitz@golang.org>
Thu, 2 May 2019 14:44:05 +0000 (14:44 +0000)
Mid-stack inlining is enable now, see #19348, but we still can not
remove the special case for runtime.heapBits.nextArena, because
runtime.heapBits.next is too complex to be inlined
(cost 96 exceeds budget 80).

Change-Id: I04ea86509074afdc83a3f70d68b8a1a8829763d1
Reviewed-on: https://go-review.googlesource.com/c/go/+/174839
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/cmd/compile/internal/gc/inl.go

index 5013c556631b38e02fab3c4863d008772184f387..addba98e3ec04b88dfe0c189ed580082af9396eb 100644 (file)
@@ -343,10 +343,6 @@ func (v *hairyVisitor) visit(n *Node) bool {
                                // runtime.heapBits.next even though
                                // it calls slow-path
                                // runtime.heapBits.nextArena.
-                               //
-                               // TODO(austin): Once mid-stack
-                               // inlining is the default, remove
-                               // this special case.
                                break
                        }
                }