]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: run the right test in TestCgoExternalThreadSignal
authorIan Lance Taylor <iant@golang.org>
Tue, 23 Nov 2021 20:25:10 +0000 (12:25 -0800)
committerIan Lance Taylor <iant@golang.org>
Tue, 23 Nov 2021 21:59:51 +0000 (21:59 +0000)
The code was accidentally repeating the TestCgoExternalThreadSIGPROF test.

While we're here remove an obsolete skip on ppc64/linux.

Change-Id: Icdc4032a67aa80fbcfcd7c5c7ab8a6f23f321e2e
Reviewed-on: https://go-review.googlesource.com/c/go/+/366755
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
src/runtime/crash_cgo_test.go

index 45ee6d690594979b7df681b17b1fb1c85ccab52f..bfb260a143d480b64ccad66fd8f2e75e68953925 100644 (file)
@@ -94,11 +94,6 @@ func TestCgoExternalThreadSIGPROF(t *testing.T) {
        case "plan9", "windows":
                t.Skipf("no pthreads on %s", runtime.GOOS)
        }
-       if runtime.GOARCH == "ppc64" && runtime.GOOS == "linux" {
-               // TODO(austin) External linking not implemented on
-               // linux/ppc64 (issue #8912)
-               t.Skipf("no external linking on ppc64")
-       }
 
        exe, err := buildTestProg(t, "testprogcgo", "-tags=threadprof")
        if err != nil {
@@ -128,7 +123,7 @@ func TestCgoExternalThreadSignal(t *testing.T) {
                t.Fatal(err)
        }
 
-       got, err := testenv.CleanCmdEnv(exec.Command(exe, "CgoExternalThreadSIGPROF")).CombinedOutput()
+       got, err := testenv.CleanCmdEnv(exec.Command(exe, "CgoExternalThreadSignal")).CombinedOutput()
        if err != nil {
                t.Fatalf("exit status: %v\n%s", err, got)
        }