]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/go: convert TestGoTestBuildsAnXtestContainingOnly... to the script framework
authorMichael Matloob <matloob@golang.org>
Mon, 13 Jan 2020 15:43:09 +0000 (10:43 -0500)
committerMichael Matloob <matloob@golang.org>
Thu, 27 Feb 2020 21:24:58 +0000 (21:24 +0000)
The name of the test is too long to fit on the first line. It's
TestGoTestBuildsAnXtestContainingOnlyNonRunnableExamples.

Part of converting all tests to script framework to improve
test parallelism.

Updates #36320
Updates #17751

Change-Id: I490748271b10a85cbe1d34f9dbecb86ccf0101a7
Reviewed-on: https://go-review.googlesource.com/c/go/+/214423
Reviewed-by: Jay Conrod <jayconrod@google.com>
src/cmd/go/go_test.go
src/cmd/go/testdata/norunexample/example_test.go [deleted file]
src/cmd/go/testdata/norunexample/test_test.go [deleted file]
src/cmd/go/testdata/script/test_no_run_example.txt [new file with mode: 0644]

index a8ef36e6bbe2a5f5d31a1a06bdfec061cd8349b0..89b27b90b733f93ec4197736e27eaad9a2bd644b 100644 (file)
@@ -1832,13 +1832,6 @@ func TestListTemplateContextFunction(t *testing.T) {
        }
 }
 
-func TestGoTestBuildsAnXtestContainingOnlyNonRunnableExamples(t *testing.T) {
-       tg := testgo(t)
-       defer tg.cleanup()
-       tg.run("test", "-v", "./testdata/norunexample")
-       tg.grepStdout("File with non-runnable example was built.", "file with non-runnable example was not built")
-}
-
 // Test that you cannot use a local import in a package
 // accessed by a non-local import (found in a GOPATH/GOROOT).
 // See golang.org/issue/17475.
diff --git a/src/cmd/go/testdata/norunexample/example_test.go b/src/cmd/go/testdata/norunexample/example_test.go
deleted file mode 100644 (file)
index e158305..0000000
+++ /dev/null
@@ -1,11 +0,0 @@
-package pkg_test
-
-import "os"
-
-func init() {
-       os.Stdout.Write([]byte("File with non-runnable example was built.\n"))
-}
-
-func Example_test() {
-       // This test will not be run, it has no "Output:" comment.
-}
diff --git a/src/cmd/go/testdata/norunexample/test_test.go b/src/cmd/go/testdata/norunexample/test_test.go
deleted file mode 100644 (file)
index d2e9198..0000000
+++ /dev/null
@@ -1,10 +0,0 @@
-package pkg
-
-import (
-       "os"
-       "testing"
-)
-
-func TestBuilt(t *testing.T) {
-       os.Stdout.Write([]byte("A normal test was executed.\n"))
-}
diff --git a/src/cmd/go/testdata/script/test_no_run_example.txt b/src/cmd/go/testdata/script/test_no_run_example.txt
new file mode 100644 (file)
index 0000000..66daa31
--- /dev/null
@@ -0,0 +1,26 @@
+go test -v norunexample
+stdout 'File with non-runnable example was built.'
+
+-- norunexample/example_test.go --
+package pkg_test
+
+import "os"
+
+func init() {
+       os.Stdout.Write([]byte("File with non-runnable example was built.\n"))
+}
+
+func Example_test() {
+       // This test will not be run, it has no "Output:" comment.
+}
+-- norunexample/test_test.go --
+package pkg
+
+import (
+       "os"
+       "testing"
+)
+
+func TestBuilt(t *testing.T) {
+       os.Stdout.Write([]byte("A normal test was executed.\n"))
+}