]> Cypherpunks repositories - gostls13.git/commitdiff
undo CL 141840043 / 65e21380cb2a
authorBrad Fitzpatrick <bradfitz@golang.org>
Mon, 29 Sep 2014 20:28:08 +0000 (13:28 -0700)
committerBrad Fitzpatrick <bradfitz@golang.org>
Mon, 29 Sep 2014 20:28:08 +0000 (13:28 -0700)
Unnecessary; covered by https://golang.org/cl/141690043

Verified by jonathan@titanous.com on golang-dev.

««« original CL description
cmd/ld: close outfile before cleanup

This prevents the temporary directory from being leaked when
the linker is run on a FUSE filesystem.

Fixes #8684.

LGTM=bradfitz
R=golang-codereviews, rsc, bradfitz
CC=golang-codereviews
https://golang.org/cl/141840043

»»»

LGTM=jonathan, iant
R=iant, jonathan
CC=golang-codereviews
https://golang.org/cl/150250045

src/cmd/ld/lib.c

index 910201bdbb7abe91295a6394a39c4ed87f32647c..f889aba8a98db5a033742180a6c6eb1846b51097 100644 (file)
@@ -531,9 +531,8 @@ char* mktempdir(void);
 void removeall(char*);
 
 static void
-cleanup(void)
+rmtemp(void)
 {
-       close(cout);
        removeall(tmpdir);
 }
 
@@ -548,7 +547,7 @@ hostlinksetup(void)
        // create temporary directory and arrange cleanup
        if(tmpdir == nil) {
                tmpdir = mktempdir();
-               atexit(cleanup);
+               atexit(rmtemp);
        }
 
        // change our output to temporary object file