]> Cypherpunks repositories - gostls13.git/commitdiff
net: run TestDialTimeout on windows
authorAlex Brainman <alex.brainman@gmail.com>
Tue, 7 Feb 2012 01:05:59 +0000 (12:05 +1100)
committerAlex Brainman <alex.brainman@gmail.com>
Tue, 7 Feb 2012 01:05:59 +0000 (12:05 +1100)
R=golang-dev, rsc
CC=bradfitz, golang-dev, mikioh.mikioh
https://golang.org/cl/5616066

src/pkg/net/dial_test.go

index 16b726311534ed7409502f90e354060ebc327a58..de35ec9f940583ab6c54bd7e3331b9cc05d3c1a3 100644 (file)
@@ -43,18 +43,17 @@ func TestDialTimeout(t *testing.T) {
                                errc <- err
                        }()
                }
-       case "darwin":
+       case "darwin", "windows":
                // At least OS X 10.7 seems to accept any number of
                // connections, ignoring listen's backlog, so resort
                // to connecting to a hopefully-dead 127/8 address.
+               // Same for windows.
                go func() {
                        _, err := DialTimeout("tcp", "127.0.71.111:80", 200*time.Millisecond)
                        errc <- err
                }()
        default:
-               // TODO(bradfitz): this probably doesn't work on
-               // Windows? SOMAXCONN is huge there.  I'm not sure how
-               // listen works there.
+               // TODO(bradfitz):
                // OpenBSD may have a reject route to 10/8.
                // FreeBSD likely works, but is untested.
                t.Logf("skipping test on %q; untested.", runtime.GOOS)