]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/cgo: remove //extern for check functions in gccgo Go prologue
authorIan Lance Taylor <iant@golang.org>
Wed, 11 May 2016 16:37:46 +0000 (09:37 -0700)
committerIan Lance Taylor <iant@golang.org>
Wed, 11 May 2016 17:07:24 +0000 (17:07 +0000)
The //extern comments are incorrect and cause undefined symbol
errorswhen building cgo code with -compiler=gccgo. The code is already
designed to use weak references, and that support relies on the cgo
check functions being treated as local functions.

Change-Id: Ib38a640cc4ce6eba74cfbf41ba7147ec88769ec0
Reviewed-on: https://go-review.googlesource.com/23014
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/cmd/cgo/out.go

index 5eab3a71b49e291938ef724ee15f93da5508f764..265a3bbe6f71c4efe7895fad17967ea2a663ae0a 100644 (file)
@@ -1360,10 +1360,8 @@ func _cgoCheckResult(interface{})
 `
 
 const gccgoGoProlog = `
-//extern runtime.cgoCheckPointer
 func _cgoCheckPointer(interface{}, ...interface{}) interface{}
 
-//extern runtime.cgoCheckResult
 func _cgoCheckResult(interface{})
 `