]> Cypherpunks repositories - gostls13.git/commitdiff
Revert "cmd/compile/internal/noder: limit the number of goroutine"
authorMatthew Dempsky <mdempsky@google.com>
Thu, 8 Apr 2021 05:48:34 +0000 (05:48 +0000)
committerMatthew Dempsky <mdempsky@google.com>
Thu, 8 Apr 2021 06:08:49 +0000 (06:08 +0000)
This reverts commit c274a7c03be7b69d54d3307b954f6a0eb298c860.

Reason for revert: this can cause a compiler deadlock, and there's
no demonstrable benefit to making the change.

Change-Id: I42325ddea68d37db16fd0061c5baaee112b755b7
Reviewed-on: https://go-review.googlesource.com/c/go/+/308369
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Robert Griesemer <gri@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>

src/cmd/compile/internal/noder/noder.go

index 2c021cc570439cf84abd2ba2e4b094852b33dd6f..4c7c9fc322f97726ceabf3368dc2fd906a20e606 100644 (file)
@@ -46,8 +46,8 @@ func LoadPackage(filenames []string) {
                noders[i] = &p
 
                filename := filename
-               sem <- struct{}{}
                go func() {
+                       sem <- struct{}{}
                        defer func() { <-sem }()
                        defer close(p.err)
                        fbase := syntax.NewFileBase(filename)