]> Cypherpunks repositories - gostls13.git/commitdiff
net/http/httptrace: clarify ClientTrace docs
authorBrad Fitzpatrick <bradfitz@golang.org>
Fri, 21 Oct 2016 11:14:36 +0000 (12:14 +0100)
committerBrad Fitzpatrick <bradfitz@golang.org>
Fri, 21 Oct 2016 20:52:17 +0000 (20:52 +0000)
The old wording over-promised.

Fixes #16957

Change-Id: Iaac04de0d24eb17a0db66beeeab9de70d0f6d391
Reviewed-on: https://go-review.googlesource.com/31735
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Tom Bergan <tombergan@google.com>
src/net/http/httptrace/trace.go

index 5b042c097fea48e340ec5f18fa6ed19308f1516c..807bc4ed69323781e96a69cd59edb44f50cb65ce 100644 (file)
@@ -68,9 +68,8 @@ func WithClientTrace(ctx context.Context, trace *ClientTrace) context.Context {
 
 // ClientTrace is a set of hooks to run at various stages of an outgoing
 // HTTP request. Any particular hook may be nil. Functions may be
-// called concurrently from different goroutines, starting after the
-// call to Transport.RoundTrip and ending either when RoundTrip
-// returns an error, or when the Response.Body is closed.
+// called concurrently from different goroutines and some may be called
+// after the request has completed or failed.
 type ClientTrace struct {
        // GetConn is called before a connection is created or
        // retrieved from an idle pool. The hostPort is the