]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/cgo/internal/testshared: strip newline from gccgo -dumpversion
authorPaul E. Murphy <murp@ibm.com>
Wed, 14 Jun 2023 20:20:11 +0000 (15:20 -0500)
committerPaul Murphy <murp@ibm.com>
Fri, 16 Jun 2023 18:26:01 +0000 (18:26 +0000)
Otherwise, gccgo tests may be quietly skipped.

For #60798

Change-Id: Iaad6b53c95ad4d407b917d8f62978979b82a4e81
Reviewed-on: https://go-review.googlesource.com/c/go/+/503495
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Paul Murphy <murp@ibm.com>
TryBot-Result: Gopher Robot <gobot@golang.org>

src/cmd/cgo/internal/testshared/shared_test.go

index dc880dd2c7d33dded744fd24892a38612ce32bf6..84c92fca80440f3007dc9d13d04bb2bcf856974c 100644 (file)
@@ -748,7 +748,7 @@ func requireGccgo(t *testing.T) {
        if dot > 0 {
                output = output[:dot]
        }
-       major, err := strconv.Atoi(string(output))
+       major, err := strconv.Atoi(strings.TrimSpace(string(output)))
        if err != nil {
                t.Skipf("can't parse gccgo version number %s", output)
        }