]> Cypherpunks repositories - gostls13.git/commitdiff
cmd: re-enable tests with external linking on openbsd/arm
authorJoel Sing <joel@sing.id.au>
Wed, 24 Apr 2019 12:21:53 +0000 (22:21 +1000)
committerBrad Fitzpatrick <bradfitz@golang.org>
Wed, 24 Apr 2019 16:17:27 +0000 (16:17 +0000)
Go on openbsd/arm has supported external linking for a while now, so
re-enable the external linking related tests that were previously
disabled.

Fixes #10619

Change-Id: I304eeabf3b462d53b7feda17ae390bbe2fa22069
Reviewed-on: https://go-review.googlesource.com/c/go/+/173597
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/cmd/go/note_test.go
src/cmd/objdump/objdump_test.go

index 66c5d39bf772feb02c11dda8f4cbf4cd151ce623..6d3b9b80f476ae92c401596ff6f8fb932b50adac 100644 (file)
@@ -32,8 +32,6 @@ func TestNoteReading(t *testing.T) {
        switch {
        case !build.Default.CgoEnabled:
                t.Skipf("skipping - no cgo, so assuming external linking not available")
-       case runtime.GOOS == "openbsd" && runtime.GOARCH == "arm":
-               t.Skipf("skipping - external linking not supported, golang.org/issue/10619")
        case runtime.GOOS == "plan9":
                t.Skipf("skipping - external linking not supported")
        }
index be9fe5274a18c0fd3db149cc1705730da584a6e4..0ac1d16fe3e1547c89052fbf0f5bd8899ea53e19 100644 (file)
@@ -194,10 +194,6 @@ func TestDisasmExtld(t *testing.T) {
        case "s390x":
                t.Skipf("skipping on %s, issue 15255", runtime.GOARCH)
        }
-       // TODO(jsing): Reenable once openbsd/arm has external linking support.
-       if runtime.GOOS == "openbsd" && runtime.GOARCH == "arm" {
-               t.Skip("skipping on openbsd/arm, no support for external linking, issue 10619")
-       }
        if !build.Default.CgoEnabled {
                t.Skip("skipping because cgo is not enabled")
        }