Revert "cmd/go: add telemetry counters for flag names and subcommand"

This reverts CL 559519.

Reason for revert: Broke windows/386. See https://build.golang.org/log/03594b706c425bd61fb3c65495aae6dd01b4a81b.

Fixes #65447.

Change-Id: I567bca0368168dbfb256fadba37bce3cd31aceb2
Reviewed-on: https://go-review.googlesource.com/c/go/+/560655
Reviewed-by: Bryan Mills <bcmills@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>

diff --git a/src/cmd/go/main.go b/src/cmd/go/main.go
index f62477a8392492eea561207d2589f434143754bf..2065c9a157b8efe9208bbda2c00940a699951781 100644 (file)
--- a/src/cmd/go/main.go
+++ b/src/cmd/go/main.go
@@ -97,7 +97,6 @@ func main() {
 
        flag.Usage = base.Usage
        flag.Parse()
-       counter.CountFlags("cmd/go:flag-", *flag.CommandLine)
 
        args := flag.Args()
        if len(args) < 1 {
@@ -153,7 +152,6 @@ func main() {
 
        cmd, used := lookupCmd(args)
        cfg.CmdName = strings.Join(args[:used], " ")
-       counter.Inc("cmd/go:subcommand-" + strings.ReplaceAll(cfg.CmdName, " ", "-"))
        if len(cmd.Commands) > 0 {
                if used >= len(args) {
                        help.PrintUsage(os.Stderr, cmd)
@@ -241,7 +239,6 @@ func invoke(cmd *base.Command, args []string) {
        } else {
                base.SetFromGOFLAGS(&cmd.Flag)
                cmd.Flag.Parse(args[1:])
-               counter.CountFlags("cmd/go/"+cmd.Name()+":flag-", cmd.Flag)
                args = cmd.Flag.Args()
        }
 
@@ -326,7 +323,6 @@ func handleChdirFlag() {
                _, dir, _ = strings.Cut(a, "=")
                os.Args = slices.Delete(os.Args, used, used+1)
        }
-       counter.Inc("cmd/go:flag-C")
 
        if err := os.Chdir(dir); err != nil {
                base.Fatalf("go: %v", err)