]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/compile: reject identifiers beginning with non-ASCII digit
authorRuss Cox <rsc@golang.org>
Wed, 4 Nov 2015 20:28:47 +0000 (15:28 -0500)
committerRuss Cox <rsc@golang.org>
Mon, 16 Nov 2015 20:38:42 +0000 (20:38 +0000)
Fixes #11359.

Change-Id: I0fdfa410939f7e42020cbb19d74a67e1cc3cd610
Reviewed-on: https://go-review.googlesource.com/16919
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/cmd/compile/internal/gc/lex.go
test/fixedbugs/issue11359.go [new file with mode: 0644]

index 7fd6a62dbad979a00e820cbcf4c833ef28bca93c..1f468c1dea931f1a27b5a5458276e3afd040405f 100644 (file)
@@ -1469,6 +1469,9 @@ talph:
                        if !unicode.IsLetter(r) && !unicode.IsDigit(r) && (importpkg == nil || r != 0xb7) {
                                Yyerror("invalid identifier character U+%04x", r)
                        }
+                       if cp.Len() == 0 && unicode.IsDigit(r) {
+                               Yyerror("identifier cannot begin with digit U+%04x", r)
+                       }
                        cp.WriteRune(r)
                } else if !isAlnum(c) && c != '_' {
                        break
diff --git a/test/fixedbugs/issue11359.go b/test/fixedbugs/issue11359.go
new file mode 100644 (file)
index 0000000..6ffffed
--- /dev/null
@@ -0,0 +1,11 @@
+// errorcheck
+
+// Copyright 2015 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+// identifiers beginning with non-ASCII digits were incorrectly accepted.
+// issue 11359.
+
+package p
+var ۶ = 0 // ERROR "identifier cannot begin with digit"