cmd/dist: add -Wstrict-prototypes to CFLAGS and fix all the compiler errors

Plan 9 compilers insist this but as we don't have Plan 9
builders, we'd better let gcc check the prototypes.

Inspired by CL 7289050.

R=golang-dev, seed, dave, rsc, lucio.dere
CC=akumar, golang-dev
https://golang.org/cl/7288056

diff --git a/src/cmd/5g/gg.h b/src/cmd/5g/gg.h
index fe427227c61f836ea0d5a68e7b177286f7b4e2fc..c45be79f41e5e78f26b3df3391731976e246bcc0 100644 (file)
--- a/src/cmd/5g/gg.h
+++ b/src/cmd/5g/gg.h
@@ -84,7 +84,7 @@ void  cgen_dcl(Node*);
 int    needconvert(Type*, Type*);
 void   genconv(Type*, Type*);
 void   allocparams(void);
-void   checklabels();
+void   checklabels(void);
 void   ginscall(Node*, int);
 
 /*

diff --git a/src/cmd/6g/gg.h b/src/cmd/6g/gg.h
index df99c1a6544a46bc8822f8245b1f9c7c39a867e7..2c9a43ffe6bb8001a7d6fee455f1b8e7c104ff36 100644 (file)
--- a/src/cmd/6g/gg.h
+++ b/src/cmd/6g/gg.h
@@ -80,7 +80,7 @@ void  cgen_dcl(Node*);
 int    needconvert(Type*, Type*);
 void   genconv(Type*, Type*);
 void   allocparams(void);
-void   checklabels();
+void   checklabels(void);
 void   ginscall(Node*, int);
 int    gen_as_init(Node*);
 void   clearslim(Node*);

diff --git a/src/cmd/8g/gg.h b/src/cmd/8g/gg.h
index b67ca1f859eddd31ecb81885aefa9638a3dcd1a0..99f9952358b965e2b40c8fd6a6636fb9c771cf11 100644 (file)
--- a/src/cmd/8g/gg.h
+++ b/src/cmd/8g/gg.h
@@ -93,7 +93,7 @@ void  cgen_dcl(Node*);
 int    needconvert(Type*, Type*);
 void   genconv(Type*, Type*);
 void   allocparams(void);
-void   checklabels();
+void   checklabels(void);
 void   ginscall(Node*, int);
 
 /*

diff --git a/src/cmd/dist/build.c b/src/cmd/dist/build.c
index 533fafb3c146a4ce6373d51b94d8e4059a6327d4..afa0c470eb8a33fc1ce283f1d02ae39d65d93547 100644 (file)
--- a/src/cmd/dist/build.c
+++ b/src/cmd/dist/build.c
@@ -398,6 +398,9 @@ setup(void)
 // gccargs is the gcc command line to use for compiling a single C file.
 static char *proto_gccargs[] = {
        "-Wall",
+       // native Plan 9 compilers don't like non-standard prototypes
+       // so let gcc catch them.
+       "-Wstrict-prototypes",
        "-Wno-sign-compare",
        "-Wno-missing-braces",
        "-Wno-parentheses",

diff --git a/src/cmd/ld/lib.h b/src/cmd/ld/lib.h
index c134729f66e2d618ae451cde430dc1acfbdf3edb..d2a8b6fbefc745da5d955a2d146a3ebeff9ff400 100644 (file)
--- a/src/cmd/ld/lib.h
+++ b/src/cmd/ld/lib.h
@@ -182,7 +182,7 @@ void        Lflag(char *arg);
 void   usage(void);
 void   adddynrel(Sym*, Reloc*);
 void   adddynrela(Sym*, Sym*, Reloc*);
-Sym*   lookuprel();
+Sym*   lookuprel(void);
 void   ldobj1(Biobuf *f, char*, int64 len, char *pn);
 void   ldobj(Biobuf*, char*, int64, char*, int);
 void   ldelf(Biobuf*, char*, int64, char*);

diff --git a/src/cmd/ld/macho.h b/src/cmd/ld/macho.h
index f5510415023fefa3095be79c1b39745b5f907b15..baea6ff03d9580bcd0056e95fdd2be62d3906e3e 100644 (file)
--- a/src/cmd/ld/macho.h
+++ b/src/cmd/ld/macho.h
@@ -50,7 +50,7 @@ struct MachoDebug {
        uint32  filesize;
 };
 
-MachoHdr*      getMachoHdr();
+MachoHdr*      getMachoHdr(void);
 MachoSeg*      newMachoSeg(char*, int);
 MachoSect*     newMachoSect(MachoSeg*, char*);
 MachoLoad*     newMachoLoad(uint32, uint32);

diff --git a/src/cmd/prof/main.c b/src/cmd/prof/main.c
index e6cc836bceb58722623e33f84988b83cc95a65fd..7a1d419611d07a1767c067713a5da4f36b0a4281 100644 (file)
--- a/src/cmd/prof/main.c
+++ b/src/cmd/prof/main.c
@@ -426,14 +426,14 @@ addppword(uvlong pc)
 }
 
 void
-startpptrace()
+startpptrace(void)
 {
        ppstart = nppdata;
        addppword(~0);
 }
 
 void
-endpptrace()
+endpptrace(void)
 {
        ppdata[ppstart] = nppdata-ppstart-1;
 }
@@ -644,7 +644,7 @@ compareleaf(const void *va, const void *vb)
 }
 
 void
-dumphistogram()
+dumphistogram(void)
 {
        int i, h, n;
        PC *x;
@@ -699,7 +699,7 @@ struct Trace {
 };
 
 void
-dumppprof()
+dumppprof(void)
 {
        uvlong i, n, *p, *e;
        int ntrace;

diff --git a/src/libmach/darwin.c b/src/libmach/darwin.c
index 63abde3136e66931edfc9ada53dcecf8da4b40bd..753d940fdcb67a032f0bb985637671c0bb133847 100644 (file)
--- a/src/libmach/darwin.c
+++ b/src/libmach/darwin.c
@@ -751,7 +751,7 @@ havet:
 static void*
 excthread(void *v)
 {
-       extern boolean_t exc_server();
+       extern boolean_t exc_server(mach_msg_header_t *, mach_msg_header_t *);
        mach_msg_server(exc_server, 2048, excport, 0);
        return 0;
 }