cmd/compile: use better fatal message for staticValue1

So the position of the wrong assignment statement will be reported,
instead of using incorrect base.Pos one.

Notice while fixing issue #73823.

Change-Id: I53f240bf99d11b5f5082ee4ca0903d9f099881b6
Reviewed-on: https://go-review.googlesource.com/c/go/+/675495
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Mateusz Poliwczak <mpoliwczak34@gmail.com>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: David Chase <drchase@google.com>

diff --git a/src/cmd/compile/internal/ir/expr.go b/src/cmd/compile/internal/ir/expr.go
index 702adfdd84ef5ee6bd595accd3f456cd949e56da..98b353147f749ff67d9b6386541dc74f89beb9e0 100644 (file)
--- a/src/cmd/compile/internal/ir/expr.go
+++ b/src/cmd/compile/internal/ir/expr.go
@@ -912,12 +912,12 @@ FindRHS:
                                break FindRHS
                        }
                }
-               base.Fatalf("%v missing from LHS of %v", n, defn)
+               base.FatalfAt(defn.Pos(), "%v missing from LHS of %v", n, defn)
        default:
                return nil
        }
        if rhs == nil {
-               base.Fatalf("RHS is nil: %v", defn)
+               base.FatalfAt(defn.Pos(), "RHS is nil: %v", defn)
        }
 
        if Reassigned(n) {

diff --git a/src/cmd/compile/internal/ir/reassignment.go b/src/cmd/compile/internal/ir/reassignment.go
index ff54f708c22ae479e539d52d8de719ab50e47b1c..ba14d078a2ff26f00264ad95e9aaedd270c214de 100644 (file)
--- a/src/cmd/compile/internal/ir/reassignment.go
+++ b/src/cmd/compile/internal/ir/reassignment.go
@@ -178,12 +178,12 @@ FindRHS:
                                break FindRHS
                        }
                }
-               base.Fatalf("%v missing from LHS of %v", n, defn)
+               base.FatalfAt(defn.Pos(), "%v missing from LHS of %v", n, defn)
        default:
                return nil
        }
        if rhs == nil {
-               base.Fatalf("RHS is nil: %v", defn)
+               base.FatalfAt(defn.Pos(), "RHS is nil: %v", defn)
        }
 
        if _, ok := ro.singleDef[n]; !ok {