]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/link: disable TestPIESize if CGO isn't enabled
authorNehal J Wani <nehaljw.kkd1@gmail.com>
Tue, 26 Jan 2021 16:29:05 +0000 (16:29 +0000)
committerCherry Zhang <cherryyz@google.com>
Mon, 1 Feb 2021 15:52:59 +0000 (15:52 +0000)
With CGO disabled, the test throws the following error:

elf_test.go:291: # command-line-arguments
    loadinternal: cannot find runtime/cgo

Change-Id: Iaeb183562ab637c714240b49e73078bdb791b35b
GitHub-Last-Rev: f8fe9afad5611411966413d17cb5874f7b0018a0
GitHub-Pull-Request: golang/go#43911
Reviewed-on: https://go-review.googlesource.com/c/go/+/286632
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Trust: Matthew Dempsky <mdempsky@google.com>

src/cmd/link/elf_test.go

index 334f050e8819f5a526062951f169d85a993efdbd..20754d09f5ac9d0c085d251463d0e172a59bfedd 100644 (file)
@@ -226,6 +226,12 @@ func main() {
 
 func TestPIESize(t *testing.T) {
        testenv.MustHaveGoBuild(t)
+
+       // We don't want to test -linkmode=external if cgo is not supported.
+       // On some systems -buildmode=pie implies -linkmode=external, so just
+       // always skip the test if cgo is not supported.
+       testenv.MustHaveCGO(t)
+
        if !sys.BuildModeSupported(runtime.Compiler, "pie", runtime.GOOS, runtime.GOARCH) {
                t.Skip("-buildmode=pie not supported")
        }