cmd/go: respect vet typecheck failures again

Now that #18395 is fixed, let's see if we can insist
on vet during go test being able to type-check
packages again.

Change-Id: Iaa55a4d9c582ba743df2347d28c24f130e16e406
Reviewed-on: https://go-review.googlesource.com/108555
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>

diff --git a/src/cmd/go/internal/work/exec.go b/src/cmd/go/internal/work/exec.go
index 7014159ceecacf8b51ad2610c05c176506355286..8f985bc0e35737f44347e121aa0285ae2a3a2b02 100644 (file)
--- a/src/cmd/go/internal/work/exec.go
+++ b/src/cmd/go/internal/work/exec.go
@@ -720,7 +720,9 @@ func (b *Builder) vet(a *Action) error {
        // so at least for now assume the bug is in vet.
        // We know of at least #18395.
        // TODO(rsc,gri): Try to remove this for Go 1.11.
-       vcfg.SucceedOnTypecheckFailure = cfg.CmdName == "test"
+       //
+       // Disabled 2018-04-20. Let's see if we can do without it.
+       // vcfg.SucceedOnTypecheckFailure = cfg.CmdName == "test"
 
        js, err := json.MarshalIndent(vcfg, "", "\t")
        if err != nil {