]> Cypherpunks repositories - gostls13.git/commitdiff
net/rpc: fix data race in benchmark
authorDmitriy Vyukov <dvyukov@google.com>
Thu, 26 Jan 2012 16:06:27 +0000 (20:06 +0400)
committerDmitriy Vyukov <dvyukov@google.com>
Thu, 26 Jan 2012 16:06:27 +0000 (20:06 +0400)
Fixes #2781.

R=golang-dev, rsc
CC=golang-dev, mpimenov
https://golang.org/cl/5577053

src/pkg/net/rpc/server_test.go

index 7536c6dd6f5a5e9c5b7c8feb2b8dc4deb0277e68..b05c63c0563d747cf4d6be5dc4c33b8d67183025 100644 (file)
@@ -518,7 +518,7 @@ func benchmarkEndToEnd(dial func() (*Client, error), b *testing.B) {
                go func() {
                        reply := new(Reply)
                        for atomic.AddInt32(&N, -1) >= 0 {
-                               err = client.Call("Arith.Add", args, reply)
+                               err := client.Call("Arith.Add", args, reply)
                                if err != nil {
                                        b.Fatalf("rpc error: Add: expected no error but got string %q", err.Error())
                                }