]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/nm: do not fail TestNM if symbol has less then 3 columns in nm output
authorAlex Brainman <alex.brainman@gmail.com>
Mon, 21 Apr 2014 11:12:18 +0000 (21:12 +1000)
committerAlex Brainman <alex.brainman@gmail.com>
Mon, 21 Apr 2014 11:12:18 +0000 (21:12 +1000)
Fixes #7829

LGTM=dave
R=golang-codereviews, aram, dave
CC=golang-codereviews
https://golang.org/cl/89830043

src/cmd/nm/nm_test.go

index b2320bdf9f733f6c75f765a25dd28e5c574f36af..829c844b491bd5213d282823f662876c86fdeab8 100644 (file)
@@ -19,16 +19,11 @@ import (
 var testData uint32
 
 func checkSymbols(t *testing.T, nmoutput []byte) {
-       switch runtime.GOOS {
-       case "linux", "darwin", "solaris":
-               t.Skip("skipping test; see http://golang.org/issue/7829")
-       }
        var checkSymbolsFound, testDataFound bool
        scanner := bufio.NewScanner(bytes.NewBuffer(nmoutput))
        for scanner.Scan() {
                f := strings.Fields(scanner.Text())
                if len(f) < 3 {
-                       t.Error("nm must have at least 3 columns")
                        continue
                }
                switch f[2] {