]> Cypherpunks repositories - gostls13.git/commitdiff
Revert "cmd/compile: add missing OINLCAll case in mayModifyPkgVar"
authorThan McIntosh <thanm@google.com>
Fri, 29 Mar 2024 21:31:56 +0000 (21:31 +0000)
committerGopher Robot <gobot@golang.org>
Fri, 29 Mar 2024 21:53:14 +0000 (21:53 +0000)
This reverts CL 575175.

Reason for revert: causes crypto/ecdh failures on longtest builders.

Change-Id: Ieed326fedf91760ac73095a42ba0237cf969843b
Reviewed-on: https://go-review.googlesource.com/c/go/+/575316
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: David Chase <drchase@google.com>
Auto-Submit: Than McIntosh <thanm@google.com>

src/cmd/compile/internal/staticinit/sched.go
test/fixedbugs/issue66585.go [deleted file]

index 6221f79625b9d8753f5880c5ec5b6803cc289cc6..4191f6997ebcf47af0475bf7479271bb1fd2ace5 100644 (file)
@@ -890,9 +890,6 @@ func mayModifyPkgVar(n ir.Node) bool {
                case ir.OCALLFUNC, ir.OCALLINTER:
                        return !ir.IsFuncPCIntrinsic(n.(*ir.CallExpr))
 
-               case ir.OINLCALL:
-                       return true
-
                case ir.OAPPEND, ir.OCLEAR, ir.OCOPY:
                        return true // could mutate a global array
 
diff --git a/test/fixedbugs/issue66585.go b/test/fixedbugs/issue66585.go
deleted file mode 100644 (file)
index fdadf59..0000000
+++ /dev/null
@@ -1,25 +0,0 @@
-// run
-
-// Copyright 2024 The Go Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style
-// license that can be found in the LICENSE file.
-
-package main
-
-var x = 0
-var a = foo()
-var b = x
-
-func foo() int {
-       x++
-       return x
-}
-
-func main() {
-       if a != 1 {
-               panic("unexpected a value")
-       }
-       if b != 1 {
-               panic("unexpected b value")
-       }
-}