]> Cypherpunks repositories - gostls13.git/commitdiff
misc/dashboard/codereview: pass user information to gobot when assigning reviewer.
authorDavid Symonds <dsymonds@golang.org>
Mon, 30 Jul 2012 04:41:04 +0000 (14:41 +1000)
committerDavid Symonds <dsymonds@golang.org>
Mon, 30 Jul 2012 04:41:04 +0000 (14:41 +1000)
R=bradfitz
CC=gobot, golang-dev, rsc
https://golang.org/cl/6457052

misc/dashboard/codereview/dashboard/cl.go

index 8665947760a420971c2885b88901d83390eaff53..181d2e40feb65917a3f520f1eb6478b0d23f9100 100644 (file)
@@ -128,7 +128,8 @@ func handleAssign(w http.ResponseWriter, r *http.Request) {
        }
 
        u := user.Current(c)
-       if _, ok := emailToPerson[u.Email]; !ok {
+       person, ok := emailToPerson[u.Email]
+       if !ok {
                http.Error(w, "Not allowed", http.StatusUnauthorized)
                return
        }
@@ -183,7 +184,7 @@ func handleAssign(w http.ResponseWriter, r *http.Request) {
                if !found {
                        c.Infof("Adding %v as a reviewer of CL %v", rev, n)
 
-                       url := fmt.Sprintf("%s?cl=%s&r=%s", gobotBase, n, rev)
+                       url := fmt.Sprintf("%s?cl=%s&r=%s&obo=%s", gobotBase, n, rev, person)
                        resp, err := urlfetch.Client(c).Get(url)
                        if err != nil {
                                c.Errorf("Gobot GET failed: %v", err)