]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/link/internal/ld: ensure mach-o debug symbols are visible to App Store
authorAman Gupta <aman@tmm1.net>
Wed, 3 Apr 2019 08:49:24 +0000 (01:49 -0700)
committerThan McIntosh <thanm@google.com>
Thu, 30 May 2019 12:01:18 +0000 (12:01 +0000)
Passing test that shows Apple's symbols utility can now read
DWARF data in go.o, after the fix in CL174538

Updates #31022 #22716 #31459

Change-Id: I56c3517ad6d0a9f39537182f63cef56bb198aa83
Reviewed-on: https://go-review.googlesource.com/c/go/+/170451
Reviewed-by: Than McIntosh <thanm@google.com>
src/cmd/link/dwarf_test.go

index 9c411ff1b83e4069c4fc698edf5f066683098b7e..897b2fc8817b44905e36afeb6a29e9a100a18519 100644 (file)
@@ -98,6 +98,8 @@ func testDWARF(t *testing.T, buildmode string, expectDWARF bool, env ...string)
                                                if bytes.HasPrefix(out, []byte("Unable to find file")) {
                                                        // This failure will cause the App Store to reject our binaries.
                                                        t.Fatalf("symbols %v: failed to parse file", filepath.Base(exe))
+                                               } else if bytes.Contains(out, []byte(", Empty]")) {
+                                                       t.Fatalf("symbols %v: parsed as empty", filepath.Base(exe))
                                                }
                                        }
                                }