]> Cypherpunks repositories - gostls13.git/commitdiff
net: don't run TestDialListenerAddr in short mode on non-builders
authorBrad Fitzpatrick <bradfitz@golang.org>
Fri, 9 Jun 2017 00:02:53 +0000 (00:02 +0000)
committerBrad Fitzpatrick <bradfitz@golang.org>
Fri, 9 Jun 2017 22:15:01 +0000 (22:15 +0000)
It listens on all addresses, which users might not want.

Updates #18806 (follow-up to feedback from CL 45088)

Change-Id: I51de2d3fc3cd88a61eb3c63018c47aea920c0549
Reviewed-on: https://go-review.googlesource.com/45157
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Mikio Hara <mikioh.mikioh@gmail.com>
src/net/dial_test.go

index 59a016a0c5fd55530d9a07b55cd4f304a4d1c689..a892bf1e140c25cf32e3c84df720a638f589bd7b 100644 (file)
@@ -893,6 +893,9 @@ func TestCancelAfterDial(t *testing.T) {
 // if the machine has halfway configured IPv6 such that it can bind on
 // "::" not connect back to that same address.
 func TestDialListenerAddr(t *testing.T) {
+       if testenv.Builder() == "" {
+               testenv.MustHaveExternalNetwork(t)
+       }
        ln, err := Listen("tcp", ":0")
        if err != nil {
                t.Fatal(err)