]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/compile/internal/types2: review of example_test.go
authorRobert Griesemer <gri@golang.org>
Tue, 23 Mar 2021 21:30:57 +0000 (14:30 -0700)
committerRobert Griesemer <gri@golang.org>
Thu, 25 Mar 2021 19:21:34 +0000 (19:21 +0000)
The changes between (equivalent, and reviewed) go/types/example_test.go
and example_test.go can be seen by comparing patchset 1 and 2. The actual
changes are removing the "// UNREVIEWED" marker.

The primary differences to go/types/example_test.go are:
- use of syntax instead of go/ast package
- no ExampleMethodSet test (types2 doesn't have MethodSet)
- some code in ExampleInfo is disabled due to less precise
  position information provided by the syntax tree

Change-Id: I035284357acc8ecb7849022b5a9d873ae2235987
Reviewed-on: https://go-review.googlesource.com/c/go/+/304249
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
src/cmd/compile/internal/types2/example_test.go

index 974acb82ef86edced9230fd30392a43023d1ab3e..714bf77821399683925a986183c984869edc93b2 100644 (file)
@@ -1,4 +1,3 @@
-// UNREVIEWED
 // Copyright 2015 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.