]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/compile: simplify code in walkPrint
authorJosh Bleecher Snyder <josharian@gmail.com>
Wed, 6 Oct 2021 20:16:02 +0000 (13:16 -0700)
committerJosh Bleecher Snyder <josharian@gmail.com>
Wed, 6 Oct 2021 21:17:08 +0000 (21:17 +0000)
Use typecheck.Conv; it does the same thing.

Change-Id: I6bf27b8e929f8016ffc8350931c8320e36584a3d
Reviewed-on: https://go-review.googlesource.com/c/go/+/354350
Trust: Josh Bleecher Snyder <josharian@gmail.com>
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>

src/cmd/compile/internal/walk/builtin.go

index 3c9ef636f823928e3b27e26ac886a1b41639267d..d0aaee03d59d07b4bd39ef861f1ea62ccc5fae30 100644 (file)
@@ -622,10 +622,7 @@ func walkPrint(nn *ir.CallExpr, init *ir.Nodes) ir.Node {
                r := ir.NewCallExpr(base.Pos, ir.OCALL, on, nil)
                if params := on.Type().Params().FieldSlice(); len(params) > 0 {
                        t := params[0].Type
-                       if !types.Identical(t, n.Type()) {
-                               n = ir.NewConvExpr(base.Pos, ir.OCONV, nil, n)
-                               n.SetType(t)
-                       }
+                       n = typecheck.Conv(n, t)
                        r.Args.Append(n)
                }
                calls = append(calls, r)