]> Cypherpunks repositories - gostls13.git/commitdiff
net/http: remove unused err parameter from cancel
authorHarald Nordgren <haraldnordgren@gmail.com>
Sun, 23 Feb 2025 10:43:23 +0000 (10:43 +0000)
committerGopher Robot <gobot@golang.org>
Mon, 24 Feb 2025 18:13:30 +0000 (10:13 -0800)
Change-Id: I91f1b93298671bcb2aa5f86a59f5794bd3e3b2a9
GitHub-Last-Rev: f2e7ffb45f7b201381e1f1a3018b523dea4249f8
GitHub-Pull-Request: golang/go#71911
Reviewed-on: https://go-review.googlesource.com/c/go/+/651220
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Damien Neil <dneil@google.com>
Auto-Submit: Damien Neil <dneil@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
src/net/http/transport.go

index 41e674188f7235a3f7ed94896cb0bad7137492ef..4a6c9288270b6c8021d0fc29d454b11e9abab5c9 100644 (file)
@@ -1358,7 +1358,7 @@ func (w *wantConn) tryDeliver(pc *persistConn, err error, idleAt time.Time) bool
 
 // cancel marks w as no longer wanting a result (for example, due to cancellation).
 // If a connection has been delivered already, cancel returns it with t.putOrCloseIdleConn.
-func (w *wantConn) cancel(t *Transport, err error) {
+func (w *wantConn) cancel(t *Transport) {
        w.mu.Lock()
        var pc *persistConn
        if w.done {
@@ -1507,7 +1507,7 @@ func (t *Transport) getConn(treq *transportRequest, cm connectMethod) (_ *persis
        }
        defer func() {
                if err != nil {
-                       w.cancel(t, err)
+                       w.cancel(t)
                }
        }()