]> Cypherpunks repositories - gostls13.git/commitdiff
time: increase timeout in negative sleep duration test
authorAndrew Gerrand <adg@golang.org>
Tue, 1 Apr 2014 21:23:35 +0000 (08:23 +1100)
committerAndrew Gerrand <adg@golang.org>
Tue, 1 Apr 2014 21:23:35 +0000 (08:23 +1100)
There's enough jitter in the scheduler on overloaded machines
that 25ms is not enough.

LGTM=dave
R=golang-codereviews, gobot, rsc, dave
CC=golang-codereviews
https://golang.org/cl/83300044

src/pkg/time/sleep_test.go

index ce2dc363222804242eb1252f1acf7da7d6a54fe0..03f8e732c9e201e1467cba5e4b70dfa4b131cf40 100644 (file)
@@ -347,19 +347,18 @@ func TestReset(t *testing.T) {
 // Test that sleeping for an interval so large it overflows does not
 // result in a short sleep duration.
 func TestOverflowSleep(t *testing.T) {
-       const timeout = 25 * Millisecond
        const big = Duration(int64(1<<63 - 1))
        select {
        case <-After(big):
                t.Fatalf("big timeout fired")
-       case <-After(timeout):
+       case <-After(25 * Millisecond):
                // OK
        }
        const neg = Duration(-1 << 63)
        select {
        case <-After(neg):
                // OK
-       case <-After(timeout):
+       case <-After(1 * Second):
                t.Fatalf("negative timeout didn't fire")
        }
 }