]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/trace: fix a javascript bug in handling import error
authorHana Kim <hakim@google.com>
Thu, 19 Oct 2017 21:47:07 +0000 (17:47 -0400)
committerHyang-Ah Hana Kim <hyangah@gmail.com>
Fri, 20 Oct 2017 16:34:50 +0000 (16:34 +0000)
When traceviewer encounters a failure of json trace import
due to data error, onImportFail tried to access an error variable
which was not yet defined.

Change-Id: I431be03f179aafacaf1fd3c62a6337e8b5bd18fb
Reviewed-on: https://go-review.googlesource.com/71970
Reviewed-by: Austin Clements <austin@google.com>
src/cmd/trace/trace.go

index 784e413335d90bcab35921881eb0004ef66a8e6e..71782877517ace263d3c52dc90463585c7b7c1cc 100644 (file)
@@ -114,7 +114,7 @@ var templTrace = `
     viewer.viewTitle = "trace";
   }
 
-  function onImportFail() {
+  function onImportFail(err) {
     var overlay = new tr.ui.b.Overlay();
     overlay.textContent = tr.b.normalizeException(err).message;
     overlay.title = 'Import error';