]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/go: skip link_syso tests in short mode
authorBryan C. Mills <bcmills@google.com>
Wed, 24 Aug 2022 14:10:12 +0000 (10:10 -0400)
committerGopher Robot <gobot@golang.org>
Wed, 24 Aug 2022 16:06:46 +0000 (16:06 +0000)
These tests invoke the system C compiler and linker.
Skipping them saves a little over half a second of time in short mode.

Updates #54423.

Change-Id: I3e8aa7b53c0c91f7d1e001ec2cd5f7b4954de52d
Reviewed-on: https://go-review.googlesource.com/c/go/+/425206
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>

src/cmd/go/testdata/script/link_syso_deps.txt
src/cmd/go/testdata/script/link_syso_issue33139.txt

index 7b458b0826a3089f97bc3740810c756900204ae1..c713304d9fdde16e74fdfb92d4fd422132be8177 100644 (file)
@@ -1,7 +1,8 @@
 # Test that syso in deps is available to cgo.
 
-[!gc] skip
+[!gc] skip 'requires syso support'
 [!cgo] skip
+[short] skip 'invokes system C compiler'
 
 # External linking is not supported on linux/ppc64.
 # See: https://github.com/golang/go/issues/8912
index 8a8cb4aa8c20f045a0c1e7c077bc950c35f95136..36746e64993cb877d4664fbb7fa4a72d1c268e58 100644 (file)
@@ -1,8 +1,10 @@
 # Test that we can use the external linker with a host syso file that is
 # embedded in a package, that is referenced by a Go assembly function.
 # See issue 33139.
+
 [!gc] skip
 [!cgo] skip
+[short] skip 'invokes system C compiler'
 
 # External linking is not supported on linux/ppc64.
 # See: https://github.com/golang/go/issues/8912