]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/go: in TestScript/gotoolchain_path, remove the user's PATH
authorBryan C. Mills <bcmills@google.com>
Mon, 18 Sep 2023 20:49:41 +0000 (16:49 -0400)
committerGopher Robot <gobot@golang.org>
Mon, 18 Sep 2023 21:44:30 +0000 (21:44 +0000)
This test checks a behavior of GOTOOLCHAIN when an appropriate
toolchain is found in PATH. That requires it to exclude any suitable
toolchain binaries from the user's $PATH, which may otherwise
interfere.

Fixes #62709.

Change-Id: Ie9161e52d33a65be0b5265cb49e9f2bc8473e057
Reviewed-on: https://go-review.googlesource.com/c/go/+/529217
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

src/cmd/go/testdata/script/gotoolchain_path.txt

index 2549fa47535ff715bae7b3585a89fc20e43899d2..9628348f7aff40367a690e509d39c0a7c44c8eb6 100644 (file)
@@ -8,11 +8,12 @@ env TESTGO_VERSION=go1.21pre3
 # Compile a fake toolchain to put in the path under various names.
 env GOTOOLCHAIN=
 mkdir $WORK/bin
-[!GOOS:plan9] env PATH=$WORK/bin${:}$PATH
-[GOOS:plan9] env path=$WORK/bin${:}$path
 go build -o $WORK/bin/ ./fakego.go  # adds .exe extension implicitly on Windows
 cp $WORK/bin/fakego$GOEXE $WORK/bin/go1.50.0$GOEXE
 
+[!GOOS:plan9] env PATH=$WORK/bin
+[GOOS:plan9] env path=$WORK/bin
+
 go version
 stdout go1.21pre3