]> Cypherpunks repositories - gostls13.git/commitdiff
debug/pe: use ws2_32.dll in TestImportTableInUnknownSection
authorAlex Brainman <alex.brainman@gmail.com>
Wed, 28 Nov 2018 08:57:13 +0000 (19:57 +1100)
committerAlex Brainman <alex.brainman@gmail.com>
Thu, 29 Nov 2018 08:30:13 +0000 (08:30 +0000)
Apparently (see
https://github.com/golang/go/issues/27904#issuecomment-442140627
for details) kernel32.dll file is not present on windows/arm, so
use ws2_32.dll instead. ws2_32.dll imports table also lives in
'.rdata' section, so ws2_32.dll is as good as kernel32.dll for
testing issue #16103.

Updates #27904

Change-Id: Ibc72b24eea9a4d85abd371ffdcf00442e711b745
Reviewed-on: https://go-review.googlesource.com/c/151480
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>

src/debug/pe/file_test.go

index 5b9fe521d2579eb839e78e0c1315719c6708ca57..9613af3a3c3c00aeedc54023c4a4d63df6aab9f3 100644 (file)
@@ -603,9 +603,9 @@ func TestImportTableInUnknownSection(t *testing.T) {
                t.Skip("skipping Windows-only test")
        }
 
-       // kernel32.dll import table is located in ".rdata" section,
+       // ws2_32.dll import table is located in ".rdata" section,
        // so it is good enough to test issue #16103.
-       const filename = "kernel32.dll"
+       const filename = "ws2_32.dll"
        path, err := exec.LookPath(filename)
        if err != nil {
                t.Fatalf("unable to locate required file %q in search path: %s", filename, err)