cmd/5c, cmd/6c, cmd/8c: make failure to optimize fatal

LGTM=bradfitz, dave, r
R=r, bradfitz, dave
CC=golang-codereviews
https://golang.org/cl/152250044

diff --git a/src/cmd/5c/reg.c b/src/cmd/5c/reg.c
index 2fbe031f44c613a23bb2c0ad56fe5411fcbac477..9024d5f496dc61b7ebf8410190aee9e030a8d5bc 100644 (file)
--- a/src/cmd/5c/reg.c
+++ b/src/cmd/5c/reg.c
@@ -406,7 +406,7 @@ loop2:
                        rgp->cost = change;
                        nregion++;
                        if(nregion >= NRGN) {
-                               warn(Z, "too many regions");
+                               fatal(Z, "too many regions");
                                goto brk;
                        }
                        rgp++;
@@ -642,11 +642,8 @@ mkvar(Addr *a, int docon)
        if(s)
                if(s->name[0] == '.')
                        goto none;
-       if(nvar >= NVAR) {
-               if(debug['w'] > 1 && s)
-                       warn(Z, "variable not optimized: %s", s->name);
-               goto none;
-       }
+       if(nvar >= NVAR)
+               fatal(Z, "variable not optimized: %s", s->name);
        i = nvar;
        nvar++;
        v = &var[i];

diff --git a/src/cmd/6c/reg.c b/src/cmd/6c/reg.c
index 348d747b729bf3f44e28a6278d79e855e402049d..6f8d3ce14d5e4887a09f6c714787e8f154852e80 100644 (file)
--- a/src/cmd/6c/reg.c
+++ b/src/cmd/6c/reg.c
@@ -585,14 +585,11 @@ loop2:
                        }
                        rgp->cost = change;
                        nregion++;
-                       if(nregion >= NRGN) {
-                               warn(Z, "too many regions");
-                               goto brk;
-                       }
+                       if(nregion >= NRGN)
+                               fatal(Z, "too many regions");
                        rgp++;
                }
        }
-brk:
        qsort(region, nregion, sizeof(region[0]), rcmp);
 
        /*
@@ -808,11 +805,8 @@ mkvar(Reg *r, Addr *a)
                        goto out;
                v++;
        }
-       if(nvar >= NVAR) {
-               if(debug['w'] > 1 && s)
-                       warn(Z, "variable not optimized: %s", s->name);
-               goto none;
-       }
+       if(nvar >= NVAR)
+               fatal(Z, "variable not optimized: %s", s->name);
        i = nvar;
        nvar++;
        v = &var[i];

diff --git a/src/cmd/8c/reg.c b/src/cmd/8c/reg.c
index e6ba8bcb3e458db2d1b5221ece45eac6fcb7bdcc..ea862f3888a4409b0c189c5276b504cda1698957 100644 (file)
--- a/src/cmd/8c/reg.c
+++ b/src/cmd/8c/reg.c
@@ -518,7 +518,7 @@ loop2:
                        rgp->cost = change;
                        nregion++;
                        if(nregion >= NRGN) {
-                               warn(Z, "too many regions");
+                               fatal(Z, "too many regions");
                                goto brk;
                        }
                        rgp++;
@@ -746,11 +746,8 @@ mkvar(Reg *r, Addr *a)
                        goto out;
                v++;
        }
-       if(nvar >= NVAR) {
-               if(debug['w'] > 1 && s)
-                       warn(Z, "variable not optimized: %s", s->name);
-               goto none;
-       }
+       if(nvar >= NVAR)
+               fatal(Z, "variable not optimized: %s", s->name);
        i = nvar;
        nvar++;
        v = &var[i];