]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/dist: make the vetall builder have test shards per os/arch
authorBrad Fitzpatrick <bradfitz@golang.org>
Tue, 28 Feb 2017 18:12:32 +0000 (18:12 +0000)
committerBrad Fitzpatrick <bradfitz@golang.org>
Tue, 28 Feb 2017 18:15:00 +0000 (18:15 +0000)
This makes the vetall builder friendly to auto-sharding by the build
coordinator.

Change-Id: I0893f5051ec90e7a6adcb89904ba08cd2d590549
Reviewed-on: https://go-review.googlesource.com/37572
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
src/cmd/dist/test.go

index ef884625a61e2730517c1baa715153ef97f48e6a..227199ca220ab5da8dd34d6b27e880e888eaea32 100644 (file)
@@ -338,16 +338,16 @@ var stdOutErrAreTerminals func() bool
 func (t *tester) registerTests() {
        if strings.HasSuffix(os.Getenv("GO_BUILDER_NAME"), "-vetall") {
                // Run vet over std and cmd and call it quits.
-               t.tests = append(t.tests, distTest{
-                       name:    "vet/all",
-                       heading: "go vet std cmd",
-                       fn: func(dt *distTest) error {
-                               // This runs vet/all for the current platform.
-                               // TODO: on a fast builder or builders, run over all platforms.
-                               t.addCmd(dt, "src/cmd/vet/all", "go", "run", "main.go", "-all")
-                               return nil
-                       },
-               })
+               for osarch := range cgoEnabled {
+                       t.tests = append(t.tests, distTest{
+                               name:    "vet/" + osarch,
+                               heading: "go vet std cmd",
+                               fn: func(dt *distTest) error {
+                                       t.addCmd(dt, "src/cmd/vet/all", "go", "run", "main.go", "-p="+osarch)
+                                       return nil
+                               },
+                       })
+               }
                return
        }